Allow keystore add to handle multiple settings #54229
Conversation
Today the keystore add command can only handle adding a single setting/value pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add keystore command to accept adding multiple settings in a single invocation.
jasontedor
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
| @@ -42,13 +46,13 @@ | |||
| private final OptionSpec<String> arguments; | |||
|
|
|||
| AddStringKeyStoreCommand() { | |||
| super("Add a string setting to the keystore", false); | |||
| this.stdinOption = parser.acceptsAll(Arrays.asList("x", "stdin"), "Read setting value from stdin"); | |||
| super("Add string settings to the keystore", false); | |||
There was a problem hiding this comment.
Would it be worth updating the equivalent text in RemoveSettingKeyStoreCommand? It still talks about removing "a setting" from the keystore, but it already supports multiple settings.
There was a problem hiding this comment.
I will handle this in a follow up.
|
|
||
| `-s, --silent`:: Shows minimal output. | ||
|
|
||
| `--stdin`:: When used with the `add` parameter, you can pass the setting value | ||
| through standard input (stdin). See <<add-string-to-keystore>>. | ||
| `--stdin`:: When used with the `add` parameter, you can pass the settings values |
There was a problem hiding this comment.
Should we document -x too?
There was a problem hiding this comment.
I notice we only have -f without --force as well.
There was a problem hiding this comment.
Thanks for noticing these. Since these are orthogonal to this change, I will handle them in a follow up.
|
7.7 being feature frozen, I was wondering if the |
| `add <settings>`:: Adds settings to the keystore. Multiple setting names can be | ||
| specified as arguments to the `add` command. By default, you are prompted for | ||
| the values of the settings. If the keystore is password protected, you are also | ||
| prompted to enter the password. If the setting already exists in the keystore, |
Today the keystore add command can only handle adding a single setting/value pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add keystore command to accept adding multiple settings in a single invocation.
Today the keystore add command can only handle adding a single setting/value pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add keystore command to accept adding multiple settings in a single invocation.
|
@bpintea This is a late addition to the feature list for 7.7.0 because it's aimed at addressing some issues on Cloud, and we don't want to wait for a fix for those until 7.8.0, which would delay it being in their hands for awhile. |
Today the keystore add command can only handle adding a single setting/value pair in a single invocation. This incurs the startup costs of the JVM many times, which in some environments can be expensive. This commit teaches the add keystore command to accept adding multiple settings in a single invocation.
Closes #54191