Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cat tasks output should respect time display settings #54536

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Cat tasks output should respect time display settings #54536

merged 2 commits into from
Apr 2, 2020

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Mar 31, 2020

The _cat/tasks endpoint was previously reporting running_time as a String instead of a TimeValue, which meant that attempts to update its display format with the time=s parameter were ignored.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

jakelandis
jakelandis approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaiera
Copy link
Member Author

jbaiera commented Apr 2, 2020

@elasticmachine update branch

@jbaiera jbaiera merged commit 701ef94 into elastic:master Apr 2, 2020
@jbaiera jbaiera deleted the fix-cat-tasks-time-setting branch April 2, 2020 20:07
@jbaiera jbaiera mentioned this pull request Apr 3, 2020
Merged
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Apr 3, 2020
@jbaiera
Cat tasks output should respect time display settings (elastic#54536)
d476aa2
@jbaiera jbaiera mentioned this pull request Apr 3, 2020
Merged
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Apr 3, 2020
@jbaiera
Cat tasks output should respect time display settings (elastic#54536)
6d918bb
@jbaiera jbaiera mentioned this pull request Apr 3, 2020
Merged
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Apr 3, 2020
@jbaiera
Cat tasks output should respect time display settings (elastic#54536)
9f42fc9
jbaiera added a commit that referenced this pull request Apr 3, 2020
@jbaiera
Cat tasks output should respect time display settings (#54536) (#54735)
548145f
jbaiera added a commit that referenced this pull request Apr 3, 2020
@jbaiera
Cat tasks output should respect time display settings (#54536) (#54736)
1ad9af5
jbaiera added a commit that referenced this pull request Apr 6, 2020
@jbaiera
Cat tasks output should respect time display settings (#54536) (#54740)
a7921e2
@jbaiera jbaiera added the v6.8.9 label Apr 6, 2020
@gaobinlong gaobinlong mentioned this pull request Apr 11, 2020
Closed
@bpintea bpintea added v7.7.0 and removed v7.7.1 labels Apr 21, 2020
@gaobinlong gaobinlong mentioned this pull request Jun 3, 2020
Closed
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
@hackery
Copy link

hackery commented Jan 27, 2022 •
edited
Loading

Does this also make it sort correctly with ...&s=running_time ? In 7.4 I see it sorting alphanumerically, like

1.2ms
10.2s
2.1h
3.6ns

... aha, yes - so it perhaps closes #35840, although there it says that this is documented behavior :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat v6.8.9 v7.7.0 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbaiera @elasticmachine @hackery @jakelandis @bpintea