Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hidden value to expand_wildcards params #54551

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Add hidden value to expand_wildcards params #54551

merged 1 commit into from
Apr 1, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 1, 2020

This commit adds the hidden enum value to all expand_wildcards params.

@russcam
Add hidden value to expand_wildcards params
7e4ef6b 
This commit adds the hidden enum value to
all expand_wildcards params
@russcam russcam requested a review from gwbrown April 1, 2020 02:22
@russcam
Copy link
Contributor Author

russcam commented Apr 1, 2020

This should be backported to 7.x and 7.7

@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
38 tasks
@cbuescher cbuescher added the :Core/Infra/REST API REST infrastructure and utilities label Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

cbuescher
cbuescher reviewed Apr 1, 2020
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gwbrown
gwbrown approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for catching this, @russcam!

@gwbrown
Copy link
Contributor

gwbrown commented Apr 1, 2020

@russcam Just to confirm: would you like me to do the backports for this? It sounds like it but I don't want to step on your toes.

@russcam
Copy link
Contributor Author

russcam commented Apr 1, 2020

I've got this, @gwbrown, no worries

@russcam russcam merged commit 581b8cd into elastic:master Apr 1, 2020
russcam added a commit that referenced this pull request Apr 1, 2020
@russcam
Add hidden value to expand_wildcards params (#54551)
a2f59a2 
This commit adds the hidden enum value to
all expand_wildcards params

(cherry picked from commit 581b8cd)
russcam added a commit that referenced this pull request Apr 1, 2020
@russcam
Add hidden value to expand_wildcards params (#54551)
6f9c362 
This commit adds the hidden enum value to
all expand_wildcards params

(cherry picked from commit 581b8cd)
@russcam
Copy link
Contributor Author

russcam commented Apr 1, 2020

ported to 7.x and 7.7.

@gwbrown, should the version label for 7.7x be v7.7.0 as opposed to v7.7.1?

@russcam russcam deleted the fix/expand_wildcards_hidden branch April 1, 2020 23:03
@gwbrown
Copy link
Contributor

gwbrown commented Apr 2, 2020

Leave it as v7.7.1, there's a script that will update the version label on merged PRs if/when we build a new 7.7.0 release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher left review comments

@gwbrown gwbrown gwbrown approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >non-issue v7.7.1 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@russcam @elasticmachine @gwbrown @cbuescher @jakelandis