-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM use Priority.IMMEDIATE for stop ILM cluster update #54909
ILM use Priority.IMMEDIATE for stop ILM cluster update #54909
Conversation
This changes the priority of the cluster state update that stops ILM altogether to `URGENT`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelemed, but a `NORMAL` priority can see the "stop ilm update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it.
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreidan, this needs to update the second half of the shutdown to also use the priority though, so both parts are urgent
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/action/TransportStopILMAction.java
Outdated
Show resolved
Hide resolved
I suggest Please sprinkle some comments throughout these cluster state updates indicating that they may be running at |
Also FWIW you can test that the task really runs at a high enough priority with something like this: elasticsearch/server/src/test/java/org/elasticsearch/cluster/ClusterHealthIT.java Lines 268 to 287 in 95a7eed
(replace |
@DaveCTurner thanks for pointing out the If you don't have a strong opinion on adding an integration test, I'd rather not, as ILM is a client of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Andrei
This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
…#55017) * ILM use Priority.IMMEDIATE for stop ILM cluster update (#54909) This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
…#55018) * ILM use Priority.IMMEDIATE for stop ILM cluster update (#54909) This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
…#55016) This changes the priority of the cluster state update that stops ILM altogether to `IMMEDIATE`. We've chosen to change this as it can be useful to temporarily stop ILM if a cluster is overwhelmed, but a `NORMAL` priority can see the "stop ILM update" not make it up the tasks queue. On the same note, we're keeping the `start ILM` cluster update priority to `NORMAL` on purpose such that we only start `ILM` if the cluster can handle it. (cherry picked from commit d67df3a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This changes the priority of the cluster state update that stops ILM
altogether to
IMMEDIATE
. We've chosen to change this as it can be useful totemporarily stop ILM if a cluster is overwhelmed, but a
NORMAL
priority can see the "stop ilm update" not make it up the tasks queue.
On the same note, we're keeping the
start ILM
cluster update priorityto
NORMAL
on purpose such that we only startILM
if the cluster canhandle it.