Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature usage version aware #55246

Merged
merged 9 commits into from
Apr 15, 2020
Merged

Make feature usage version aware #55246

merged 9 commits into from
Apr 15, 2020

Commits on Apr 15, 2020

  1. Make feature usage version aware 

    Today we indiscriminately serialize these independent of the version on
the stream, even though the other side might not understand a new
feature set usage that we have added. For example, if we add feature set
usage in 7.7 for EQL, in a mixed cluster context if a request is sent to
an old coordinating node, but the master is a new version, then it would
attempt to serialize the usage information for the new feature back to
the old coordinating node, who will blow up on the unrecognized named
writeable. This commit addresses this by making feature usage version
aware, and only serializing those that the other side would understand.
    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    35e42cc View commit details
    Browse the repository at this point in the history

  2. Further refactoring

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c99f3ff View commit details
    Browse the repository at this point in the history

  3. Last cleanups

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    3bb2d5d View commit details
    Browse the repository at this point in the history

  4. Fix comment typo

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    4d0a703 View commit details
    Browse the repository at this point in the history

  5. Fix lol

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e6c1c4d View commit details
    Browse the repository at this point in the history

  6. Cleanup

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    024b790 View commit details
    Browse the repository at this point in the history

  7. Use versioned named writeable abstraction

    @jasontedor
    jasontedor committed Apr 15, 2020
    2 Configuration menu
    Copy the full SHA
    c458420 View commit details
    Browse the repository at this point in the history

  8. Remove unneeded abstract method after rename

    @jasontedor
    jasontedor committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    a759121 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into feature-usage-version-aware

    @elasticmachine
    elasticmachine committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    52307fa View commit details
    Browse the repository at this point in the history