Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Fix ODBC metadata for DATE & TIME data types #55316

Merged
merged 2 commits into from
Apr 16, 2020
Merged

SQL: Fix ODBC metadata for DATE & TIME data types #55316

merged 2 commits into from
Apr 16, 2020

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Apr 16, 2020 •
edited
Loading

Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: #41086

@matriv
SQL: Fix ODBC metadata for DATE & TIME data types
b5b3c49 
Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: elastic#42086
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@matriv matriv requested a review from bpintea April 16, 2020 15:14
@matriv matriv requested review from costin and astefan April 16, 2020 15:51
bpintea
bpintea approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@matriv matriv merged commit c23677c into elastic:master Apr 16, 2020
@matriv matriv deleted the fix-42086 branch April 16, 2020 19:50
@matriv matriv mentioned this pull request Apr 16, 2020
Closed
@matriv
Copy link
Contributor Author

matriv commented Apr 16, 2020

Wrongly referenced issue in commit :(. This fixes: #41086

matriv added a commit to matriv/elasticsearch that referenced this pull request Apr 16, 2020
@matriv
SQL: Fix ODBC metadata for DATE & TIME data types (elastic#55316)
fbf19a5 
Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: elastic#42086
(cherry picked from commit c23677c)
matriv added a commit that referenced this pull request Apr 16, 2020
@matriv
SQL: Fix ODBC metadata for DATE & TIME data types (#55316) (#55346)
736b8a8 
Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: #41086

(cherry picked from commit c23677c)
matriv added a commit that referenced this pull request Apr 16, 2020
@matriv
SQL: Fix ODBC metadata for DATE & TIME data types (#55316) (#55345)
8abdf7c 
Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: #41086
(cherry picked from commit c23677c)
yyff pushed a commit to yyff/elasticsearch that referenced this pull request Apr 17, 2020
@matriv
SQL: Fix ODBC metadata for DATE & TIME data types (elastic#55316)
ed28b06 
Fix MINIMUM_SCALE, MAXIMUM_SCALE and SQL_DATETIME_SUB
ODBC metadata for the DATE & TIME data types.

Fixes: elastic#42086
@bpintea bpintea added v7.7.0 and removed v7.7.1 labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v7.7.0 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: TIME and DATE types metadata attributes corrections
4 participants
@matriv @elasticmachine @bpintea @jakelandis