Convert TermQuery to PrefixQuery if PHRASE_PREFIX is set #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return prefixQuery; | ||
| } if (query instanceof TermQuery) { |
There was a problem hiding this comment.
I think it should either be an else if or the if should be on the next line.
|
Apart from a minor indentation issue, the fix looks good to me. +1 to merge it! |
|
pushed an update |
We miss to add a single term to a prefix query if the query in only a single term. Closes elastic#5551
|
LGTM |
clintongormley
added
>bug
v2.0.0-beta1
v1.2.0
v1.1.1
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We miss to add a single term to a prefix query if the query in only a
single term.
Closes #5551