[ML] automatically update deprecated datafeed aggregations #55678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
commented
Apr 23, 2020
| import java.util.Collections; | ||
| import java.util.Map; | ||
|
|
||
| public class AggProviderWireSerializationTests extends AbstractBWCWireSerializationTestCase<AggProvider> { |
There was a problem hiding this comment.
toXContent for the agg provider should only provide the agg map. This test is to make sure that we appropriate write between nodes of various versions.
| .setId(datafeedConfig.getId()) | ||
| .build()) | ||
| .collect(Collectors.toList()); | ||
| if (updates.isEmpty()) { |
There was a problem hiding this comment.
If there are no datafeed configs, that also means there won't be any updates.
This is ok, as all new datafeed configs enforce the appropriate date_histogram agg format.
droberts195
approved these changes
Apr 28, 2020
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlAutoUpdateService.java
Outdated
Show resolved
Hide resolved
...k/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/datafeed/DatafeedConfigAutoUpdater.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an auto update service. The first automatic update is rewriting datafeed aggregations if they exist.
closes #51606