Fix time_zone for query_string and date fields
#55881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `time_zone` parameter in `query_string` queries gets applied correctly only when using the range syntax, e.g "date:[2020-01-02 TO 2020-01-05]. When a date field gets searched without explicit range syntax, e.g. "date:"2020-01-01" we internally create a range query than uses the specified date as start date and rounds up to the next underspecified units for the end date (e.g. here 2020-01-01T23:59:59) without considering the `time_zone` settings. This change adds a check in QueryStringQueryParser to detect this scenario early where we have access to the time zone information and directly create a range query using it. Closes elastic#55813
cbuescher
added
>bug
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
cbuescher
changed the title
time_zone on query_string and date fieldstime_zone for query_string and date fields
|
@elasticmachine update branch |
mayya-sharipova
approved these changes
May 12, 2020
|
@mayya-sharipova thanks for the review! |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
May 13, 2020
Currently the `time_zone` parameter in `query_string` queries gets applied correctly only when using the range syntax, e.g "date:[2020-01-02 TO 2020-01-05]. When a date field gets searched without explicit range syntax, e.g. "date:"2020-01-01" we internally create a range query than uses the specified date as start date and rounds up to the next underspecified units for the end date (e.g. here 2020-01-01T23:59:59) without considering the `time_zone` settings. This change adds a check in QueryStringQueryParser to detect this scenario early where we have access to the time zone information and directly create a range query using it. Closes elastic#55813
cbuescher
pushed a commit
that referenced
this pull request
May 13, 2020
Currently the `time_zone` parameter in `query_string` queries gets applied correctly only when using the range syntax, e.g "date:[2020-01-02 TO 2020-01-05]. When a date field gets searched without explicit range syntax, e.g. "date:"2020-01-01" we internally create a range query than uses the specified date as start date and rounds up to the next underspecified units for the end date (e.g. here 2020-01-01T23:59:59) without considering the `time_zone` settings. This change adds a check in QueryStringQueryParser to detect this scenario early where we have access to the time zone information and directly create a range query using it. Closes #55813
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
May 13, 2020
…astic#56668) Currently the `time_zone` parameter in `query_string` queries gets applied correctly only when using the range syntax, e.g "date:[2020-01-02 TO 2020-01-05]. When a date field gets searched without explicit range syntax, e.g. "date:"2020-01-01" we internally create a range query than uses the specified date as start date and rounds up to the next underspecified units for the end date (e.g. here 2020-01-01T23:59:59) without considering the `time_zone` settings. This change adds a check in QueryStringQueryParser to detect this scenario early where we have access to the time zone information and directly create a range query using it. Closes elastic#55813
cbuescher
pushed a commit
that referenced
this pull request
May 13, 2020
Currently the `time_zone` parameter in `query_string` queries gets applied correctly only when using the range syntax, e.g "date:[2020-01-02 TO 2020-01-05]. When a date field gets searched without explicit range syntax, e.g. "date:"2020-01-01" we internally create a range query than uses the specified date as start date and rounds up to the next underspecified units for the end date (e.g. here 2020-01-01T23:59:59) without considering the `time_zone` settings. This change adds a check in QueryStringQueryParser to detect this scenario early where we have access to the time zone information and directly create a range query using it. Closes #55813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
time_zoneparameter inquery_stringqueries gets appliedcorrectly only when using the range syntax, e.g "date:[2020-01-02 TO
2020-01-05]. When a date field gets searched without explicit range syntax, e.g.
"date:"2020-01-01" we internally create a range query than uses the specified
date as start date and rounds up to the next underspecified units for the end
date (e.g. here 2020-01-01T23:59:59) without considering the
time_zonesettings. This change adds a check in QueryStringQueryParser to detect this
scenario early where we have access to the time zone information and directly
create a range query using it.
Closes #55813