Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove codec from ilm action forcemerge #55978

Closed
wants to merge 1 commit into from
Closed

Remove codec from ilm action forcemerge #55978

wants to merge 1 commit into from
+0 −11

Conversation

freakingid
Copy link

codec was removed at some point in the past, yet the documentation still lists it.

The issue: #41274
and its associated PR: #49974
... seem to be adding "codec" to ILM action forcemerge in version 7.7. However, older docs need corrected.

@freakingid
Remove codec from ilm action forcemerge
ca2cc30 
`codec` was removed at some point in the past, yet the documentation still lists it.
@cbuescher cbuescher added :Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes labels Apr 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Apr 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Apr 30, 2020
debadair
debadair approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DaveCTurner
DaveCTurner requested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, we do support setting the codec, but it's called index_codec for reasons I do not currently understand. I'm raising this with the team.

@DaveCTurner DaveCTurner mentioned this pull request May 21, 2020
Closed
@jrodewig
Copy link
Contributor

jrodewig commented Oct 14, 2020 •
edited
Loading

With #62243, index_codec is now documented: https://www.elastic.co/guide/en/elasticsearch/reference/current/ilm-forcemerge.html

I'm going to close this PR. Please feel free to re-open if I missed something. Thanks!

@jrodewig jrodewig closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner requested changes

@debadair debadair debadair approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freakingid @elasticmachine @jrodewig @debadair @DaveCTurner @cbuescher