Fix max-int limit for number of points reduced in geo_centroid #56370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in InternalGeoCentroid#reduce existed that summed up the aggregation's long-valued counts into a local integer variable. Since it is definitely possible to reduce more than Integer.MAX points, this change simply updates that variable to be a long-valued number. Closes elastic#55992.
talevy
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
nik9000
reviewed
May 7, 2020
| @@ -115,7 +115,7 @@ public long count() { | |||
| public InternalGeoCentroid reduce(List<InternalAggregation> aggregations, ReduceContext reduceContext) { | |||
| double lonSum = Double.NaN; | |||
| double latSum = Double.NaN; | |||
| int totalCount = 0; | |||
| long totalCount = 0; | |||
There was a problem hiding this comment.
Huh! The count member variable was always a long!
...er/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalGeoCentroidTests.java
Outdated
Show resolved
Hide resolved
|
thanks Nik! |
talevy
added a commit
that referenced
this pull request
May 7, 2020
A bug in InternalGeoCentroid#reduce existed that summed up the aggregation's long-valued counts into a local integer variable. Since it is definitely possible to reduce more than Integer.MAX points, this change simply updates that variable to be a long-valued number. Closes #55992.
talevy
added a commit
that referenced
this pull request
May 7, 2020
A bug in InternalGeoCentroid#reduce existed that summed up the aggregation's long-valued counts into a local integer variable. Since it is definitely possible to reduce more than Integer.MAX points, this change simply updates that variable to be a long-valued number. Closes #55992.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in InternalGeoCentroid#reduce existed that summed up
the aggregation's long-valued counts into a local integer variable.
Since it is definitely possible to reduce more than Integer.MAX points,
this change simply updates that variable to be a long-valued number.
Closes #55992.