Move common repository configuration to java plugin #57057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the common maven repository configuration to the ES java plugin. All java projects need this common set of repos. Note that the Elastic download and maven repos are removed, as they are not necessary anymore since distribution download was split into the DistributionDownloadPlugin.
rjernst
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
Note this also removes BuildPlugin.configureConfigurations which was dead code as it had already been migrated to ElasticsearchJavaPlugin. |
mark-vieira
approved these changes
May 21, 2020
| public static void configureRepositories(Project project) { | ||
| // ensure all repositories use secure urls | ||
| project.getRepositories().all(repository -> { | ||
| if (repository instanceof MavenArtifactRepository) { |
There was a problem hiding this comment.
I think we can now replace all of this with the following which was introduced in Gradle 6.0.
if (repository instanceof UrlArtifactRepository) {
((UrlArtifactRepository) repository).setAllowInsecureProtocol(false);
}
There was a problem hiding this comment.
I was not able to do this because the gradle setting only controls a deprecation warning, it does not fail the build.
rjernst
added a commit
that referenced
this pull request
May 26, 2020
This commit moves the common maven repository configuration to the ES java plugin. All java projects need this common set of repos. Note that the Elastic download and maven repos are removed, as they are not necessary anymore since distribution download was split into the DistributionDownloadPlugin.
rjernst
added a commit
that referenced
this pull request
May 26, 2020
This commit moves the common maven repository configuration to the ES java plugin. All java projects need this common set of repos. Note that the Elastic download and maven repos are removed, as they are not necessary anymore since distribution download was split into the DistributionDownloadPlugin.
rjernst
added a commit
that referenced
this pull request
May 26, 2020
This commit moves the common maven repository configuration to the ES java plugin. All java projects need this common set of repos. Note that the Elastic download and maven repos are removed, as they are not necessary anymore since distribution download was split into the DistributionDownloadPlugin.
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the common maven repository configuration to the ES
java plugin. All java projects need this common set of repos. Note that
the Elastic download and maven repos are removed, as they are not
necessary anymore since distribution download was split into the
DistributionDownloadPlugin.