Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trimUnsafeCommits for indices created before 6.2 #57222

Merged
merged 2 commits into from May 27, 2020
Merged

Fix trimUnsafeCommits for indices created before 6.2 #57222

merged 2 commits into from May 27, 2020

Commits on May 27, 2020

  1. Fix trimUnsafeCommits for indices created before 6.2 (elastic#57187) 

    If an upgraded node is restarted multiple times without flushing a new 
index commit, then we will wrongly exclude all commits from the starting
commits. This bug is reproducible with these minimal steps: (1) create
an empty index on 6.1.4 with translog retention disabled, (2) upgrade 
the cluster to 7.7.0, (3) restart the upgraded the cluster. The problem
is that with the new translog policy can trim translog without having a
new index commit, while the existing commit still refers to the previous
translog generation.

Closes elastic#57091
    @dnhatn
    dnhatn committed May 27, 2020
    Copy the full SHA
    6769ec5 View commit details
    Browse the repository at this point in the history

  2. fix test

    @dnhatn
    dnhatn committed May 27, 2020
    Copy the full SHA
    12bcb59 View commit details
    Browse the repository at this point in the history