Wildcard field fix for scripts - changed value type from BytesRef to String #58060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>bug
:Search/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
markharwood
force-pushed
the
fix/58044
branch
3 times, most recently
from
c55adb7
to
b1450e5
Compare
This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values. Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts. Closes elastic#58044
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Jun 15, 2020
elastic#58060) This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values. Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts. Closes elastic#58044
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts accessing wildcard fields currently get ByteRefs instead of Strings which would be more useful and compatible with
keywordfields. This PR addresses that.We have existing tests that check that
binaryfields return ByteRefs so we have to preserve that behaviour for non-wildcardfields.Existing BytesBinaryDVLeafFieldData assumes ByteRefs are required in scripts so I pulled most of its existing logic up into a common abstract class and created a new subclass with the required override to provide String-based return type. All other changes stem from that refactoring.
I wasn't too comfortable about the naming of new classes - "StringBinaryDV" seems like a contradiction but "WildcardBinaryDv" seems clumsy too (saying more about how we want to search than the data type).
Closes #58044