Executes incremental reduce in the search thread pool #58461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change forks the execution of partial reduces in the coordinating node to the search thread pool. It also ensures that partial reduces are executed sequentially and asynchronously in order to limit the memory and cpu that a single search request can use but also to avoid blocking a network thread. If a partial reduce fails with an exception, the search request is cancelled and the reporting of the error is delayed to the start of the fetch phase (when the final reduce is performed). This ensures that we cleanup the in-flight search requests before returning an error to the user. Closes elastic#53411 Relates elastic#51857
jimczi
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
javanna
reviewed
Jun 25, 2020
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/FetchPhase.java
Outdated
Show resolved
Hide resolved
nik9000
reviewed
Jul 13, 2020
There was a problem hiding this comment.
I left a few things, mostly small. I think this is the sort of thing that we need, but I also feel like I don't know JVM threading stuff well enough to be super clear. I feel like we're being fairly paranoid here with the threading stuff. Which is probably fine because this won't trigger on small searches. But I don't know enough to be sure that my instinct is right about it either.
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Show resolved
Hide resolved
nik9000
approved these changes
Jul 27, 2020
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Jul 28, 2020
This change forks the execution of partial reduces in the coordinating node to the search thread pool. It also ensures that partial reduces are executed sequentially and asynchronously in order to limit the memory and cpu that a single search request can use but also to avoid blocking a network thread. If a partial reduce fails with an exception, the search request is cancelled and the reporting of the error is delayed to the start of the fetch phase (when the final reduce is performed). This ensures that we cleanup the in-flight search requests before returning an error to the user. Closes #53411 Relates #51857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change forks the execution of partial reduces in the coordinating node to the search thread pool.
It also ensures that partial reduces are executed sequentially and asynchronously in order to limit the
memory and cpu that a single search request can use but also to avoid blocking a network thread.
If a partial reduce fails with an exception, the search request is cancelled and the reporting of the error is
delayed to the start of the fetch phase (when the final reduce is performed). This ensures that we cleanup the
in-flight search requests before returning an error to the user.
Closes #53411
Relates #51857