Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance real memory circuit breaker with G1 GC #58674

Merged
merged 19 commits into from Jul 13, 2020
Merged

Enhance real memory circuit breaker with G1 GC #58674

merged 19 commits into from Jul 13, 2020

Commits on Jun 29, 2020

  1. Enhance real memory circuit breaker with G1 GC 

    Using G1 GC, Elasticsearch can rarely trigger that heap usage goes above
the real memory circuit breaker limit and stays there for an extended
period. This situation will persist until the next young GC. The circuit
breaking itself hinders that from occurring in a timely manner since it
breaks all request before real work is done.

This commit gently nudges G1 to do a young GC and then double checks
that heap usage is still above the real memory circuit breaker limit
before throwing the circuit breaker exception.

Related to elastic#57202
    @henningandersen
    henningandersen committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    05ec98a View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Time not monotonic.

    @henningandersen
    henningandersen committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    b6b565a View commit details
    Browse the repository at this point in the history

  2. Add link to JDK G1 region size calculation.

    @henningandersen
    henningandersen committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    c8ac1af View commit details
    Browse the repository at this point in the history

  3. Rename to "over limit" rather than "double check"

    @henningandersen
    henningandersen committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    1d007ca View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into enhance_g1_circuit_… 

    …breaking
    @henningandersen
    henningandersen committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    66d642d View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Keep maxHeap in field.

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3eacf32 View commit details
    Browse the repository at this point in the history

  2. Improved logging.

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    addeede View commit details
    Browse the repository at this point in the history

  3. Also check young GC counts.

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    110925d View commit details
    Browse the repository at this point in the history

  4. Move wiring into createDoubleCheckStrategy.

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    cfde2a7 View commit details
    Browse the repository at this point in the history

  5. createOverLimitStrategy naming

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fea2ddc View commit details
    Browse the repository at this point in the history

  6. Use Booleans.parseBoolean

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    845dc10 View commit details
    Browse the repository at this point in the history

  7. Always call the over limit strategy 

    Now determine strategy based on whether real memory usage is
tracked.
    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3f61f93 View commit details
    Browse the repository at this point in the history

  8. Fix test stability 

    Test would not always trigger the over limit check twice, fixed.
    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    55a1774 View commit details
    Browse the repository at this point in the history

  9. Improved code formatting

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ed460f9 View commit details
    Browse the repository at this point in the history

  10. Better field order.

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7d148d0 View commit details
    Browse the repository at this point in the history

  11. Few line reorderings

    @henningandersen
    henningandersen committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    263f474 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Merge remote-tracking branch 'origin/master' into enhance_g1_circuit_… 

    …breaking
    @henningandersen
    henningandersen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    79bd399 View commit details
    Browse the repository at this point in the history

  2. Added lock timeout.

    @henningandersen
    henningandersen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    facd321 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Merge branch 'master' into enhance_g1_circuit_breaking

    @elasticmachine
    elasticmachine committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    14e574c View commit details
    Browse the repository at this point in the history