Fix NPE in SnapshotService CS Application #58680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unlikely corner case of deleting a relocation (hence `WAITING`) primary shard's index during a partial snapshot, we would throw an NPE when checking if there's any external changes to process.
original-brownbear
added
>bug
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 29, 2020
Relates to elastic#58680. Bugs like that should not only show up in logs but ideally also get caught in tests. We expect to never see exceptions in these two spots.
|
Found this while going for 100% coverage in #56911 but could then also find it in the wild in production logs. |
tlrx
approved these changes
Jun 30, 2020
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 30, 2020
In the unlikely corner case of deleting a relocation (hence `WAITING`) primary shard's index during a partial snapshot, we would throw an NPE when checking if there's any external changes to process.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 30, 2020
In the unlikely corner case of deleting a relocation (hence `WAITING`) primary shard's index during a partial snapshot, we would throw an NPE when checking if there's any external changes to process.
original-brownbear
added a commit
that referenced
this pull request
Jun 30, 2020
original-brownbear
added a commit
that referenced
this pull request
Jun 30, 2020
original-brownbear
added a commit
that referenced
this pull request
Jul 14, 2020
Relates to #58680. Bugs like that should not only show up in logs but ideally also get caught in tests. We expect to never see exceptions in these two spots.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 14, 2020
Relates to elastic#58680. Bugs like that should not only show up in logs but ideally also get caught in tests. We expect to never see exceptions in these two spots.
original-brownbear
added a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unlikely corner case of deleting a relocation (hence
WAITING) primary shard'sindex during a partial snapshot, we would throw an NPE when checking if there's any external
changes to process.