Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw ESRejectedExecutionException when too many pending listeners #59036

Merged
merged 1 commit into from Jul 8, 2020
Merged

Throw ESRejectedExecutionException when too many pending listeners #59036

merged 1 commit into from Jul 8, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 4, 2020 •
edited

The backport in #56073 was supposed to change the max pending listeners to 1000 and throw ESRejectedExecutionException instead of RejectedExecutionException when reaching that limit. However, it missed the latter.

Closes #53225

@dnhatn dnhatn added >non-issue :Distributed/Network Http and internode communication implementations :Distributed/CCR Issues around the Cross Cluster State Replication features v6.8.11 labels Jul 4, 2020
@dnhatn dnhatn requested a review from Tim-Brooks July 4, 2020 19:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jul 4, 2020
@dnhatn dnhatn mentioned this pull request Jul 4, 2020
Closed
Tim-Brooks
Tim-Brooks approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jul 8, 2020

Thanks Tim!

@dnhatn dnhatn merged commit 00bf386 into elastic:6.8 Jul 8, 2020
@dnhatn dnhatn deleted the 6.8-remote-full-connect-queue branch July 8, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Brooks Tim-Brooks Tim-Brooks approved these changes

Assignees
No one assigned
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features :Distributed/Network Http and internode communication implementations >non-issue Team:Distributed Meta label for distributed team v6.8.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnhatn @elasticmachine @Tim-Brooks