Fix node health-check-related test failures #59277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#52680 we introduced a new health check mechanism. This commit fixes up some sporadic related test failures, and improves the behaviour of the `FollowersChecker` slightly in the case that no retries are configured. Closes elastic#59252 Closes elastic#59172
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
commented
Jul 9, 2020
| @@ -327,16 +327,16 @@ public void handleException(TransportException exp) { | |||
| failureCountSinceLastSuccess++; | |||
|
|
|||
| final String reason; | |||
| if (failureCountSinceLastSuccess >= followerCheckRetryCount) { | |||
There was a problem hiding this comment.
We should check the failure count last so we can report more specific errors (disconnected etc) if available.
| @@ -325,7 +324,7 @@ public FileChannel newFileChannel(Path path, Set<? extends OpenOption> options, | |||
| @Override | |||
| public void force(boolean metaData) throws IOException { | |||
| if (injectIOException.get()) { | |||
| if (path.toString().startsWith(pathPrefix) && path.toString().endsWith(".es_temp_file")) { | |||
There was a problem hiding this comment.
No need to check the path starts with / and, indeed, it doesn't on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #52680 we introduced a new health check mechanism. This commit fixes
up some sporadic related test failures, and improves the behaviour of
the
FollowersCheckerslightly in the case that no retries areconfigured.
Closes #59252
Closes #59172