Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for keyword script field's fielddata #59523

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 14, 2020

Adds tests for the keyword typed script field's fielddata
implementation. One unit test which runs quickly and an integretion test
for fetching and an integration test for the terms agg.

Relates to #59332

Adds tests for the `keyword` typed `script` field's fielddata
implementation. One unit test which runs quickly and an integretion test
for fetching and an integration test for the `terms` agg.
@nik9000 nik9000 added the :Search/Search Search-related issues that do not fall into other categories label Jul 14, 2020
@nik9000 nik9000 requested a review from javanna July 14, 2020 11:56
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot!

@nik9000
Copy link
Member Author

nik9000 commented Jul 14, 2020

LGTM thanks a lot!

👍

@nik9000 nik9000 merged commit 46fcc58 into elastic:feature/runtime_fields Jul 14, 2020
@javanna javanna mentioned this pull request Jul 15, 2020
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants