Tie-break suggestions by term #5978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked to Simon ... he feels we should fix this for 1.2. |
…default analyzer that favors xorr because xorr-the bigram was seen
|
LGTM - can you squash and push? |
|
OK will do ... |
mikemccand
added a commit
that referenced
this pull request
May 18, 2014
If the score for two suggestions is the same, we now tie break by term; earlier terms (aaa) sort before later terms (zzz). Closes #5978
clintongormley
added
the
:Search/Suggesters
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, DirectCandidateGenerator.CandidateSet.candidates also required
tie-breaking because CandidateScorer.findBestCandidates would change
its results depending on the sort order of the candidates in each
CandidateSet. And it was tricky because the tests would
intermittently fail since BytesRef.hashCode is different for
every JVM instance...
So I added an Arrays.sort in addCandidates, and fixed Correction and
Candidate to implement Comparable, and fixed CandidateScorer.updateTop
to use .compareTo when checking if the new correction competes with
the top of the PQ.
I folded in Simon's comment as-is into SuggestSearchTests, but I still
don't fully understand the test, e.g. why after
"phraseSuggestion.analyzer(null);" would this get bigram to
participate in scoring again? (The previous test did
.forceUnigrams(true) which I think is why xorn/xorr were tied for score).