Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Add option to provide the delimiter for the CSV format #59907

Merged
merged 9 commits into from
Jul 29, 2020

Commits on Jul 20, 2020

  1. Add option to provide the delimiter to the CSV fmt

    This adds the option to provide the desired character as the separator
    for the CSV format (the default remains comma).
    A set of characters are excluded though - like CR, LF, `"` - to avoid
    slipping onto the CSV-dialects slope. The tab is also forbidden, the
    user needs to choose the "tsv" format explicitely.
    
    The TSV format also gets a needed supplemental escaping, that of the '\'
    character.
    bpintea committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b910a89 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Correct delimiter value propagation. Adress comm.

    Fix the way the delimiter is being passed around, removing the CSV
    member - since its instantiation is a singleton - and pushing it through
    function arguments.
    
    The commit fixes a few issues with the "header" URL attribute:
    - these was no longer usable, since it wasn't "consumed" by
    RestSqlQueryAction before generating the answer (triggering an error
    responce on use);
    - its value was only checked against "absent", so an incorrect value
    (typo like "abaent") could have silently generated an unexpected reply.
    - missing
    
    Documentation for the "delimiter" attribute has also been added.
    bpintea committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    6d5b28a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Adress review comments. Unescape param

    The commit unescapes the deliter param. This is required for the
    doc-sourced tests.
    
    Also, implement a switch for param value validation and fix docs.
    bpintea committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    2b3c351 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9bcff1 View commit details
    Browse the repository at this point in the history
  3. Update docs/reference/sql/endpoints/rest.asciidoc

    Co-authored-by: Marios Trivyzas <matriv@gmail.com>
    bpintea and matriv committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    1b3958d View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Address review comments

    - rip out anything which isn't Delimiter-related.
    - undo 'hasHeader' method renaming.
    bpintea committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    41c3fbf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ccf1d86 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Minor doc update. One more fix revert

    Update the doc to make it clear that the textual CSV, TSV and TXT
    formats pass the cursor back to the user through the Cursor HTTP header.
    bpintea committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    6d014df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5adc138 View commit details
    Browse the repository at this point in the history