Simplify jdk downloads via artifact transforms (7.x backport) #60803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify jdk downloads via artifact transforms This reworks the jdk download plugin to use artifact transforms. That allows us to simplify the jdk download plugin by a lot. The benefits of using artifact transforms are: - they transform an artifact to an upacked folder on the fly as part of the dependenc resolution allowing us to remove all the custom created unpack tasks and configurations - Artifact transforms support gradle build cache. Requesting a jdk folder on a clean machine will likely be resolved from the build cache - The manual mingling about not extracting jdks multiple times by all jdks channeling through root project configurations can be removed as they support up-to-date checking and build cache which will ensure these archives are only resolved once per build at max. Also the test coverage has been ported to Spock that supports data driven testing. This porting includes an introduction to a wiremock fixture that can be used later on for mocking repository urls in other integration tests * Simplify artifact transform registration * Change jdk finalization and repository setup Jdk finalization is now done via `configuration.defaultDependencies`. This has two benefits: - we only configure and finalize the JDKs we actually use during the build - afterEvaluate hooks are problematic in combination with task avoidance api. Relying on task avoidance api in Gradle moves more configuration logic into the materialization of tasks which is, with task avoidance api, is done ideally during the task graph calculation. Anything created (e.g. jdks) created late in this task graph calculation would never be finalized via afterEvaluate hooks as this has been fired before already with the jdk not there yet. Furthermore we now only configure repositories in the projects where the jdk is declared (aka the jdk-download plugin is applied) and only if the jdk is actually requested during the build. * Fix javadoc * Fix jdk download repo content filtering * Minor cleanup * Apply review feedback and cleanup
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #60713 to 7.x branch