Fail invalid incremental cluster state writes #61030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is disastrous if we commit an incremental cluster state update without having written the full state first. We assert that this doesn't happen, but it is hard to fully test the myriad ways that things might fail in a messy production environment. Given the disastrous consequences it is worth erring on the side of caution in this area. This commit fails invalid writes even if assertions are disabled.
DaveCTurner
added
>enhancement
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
deleted the
2020-08-12-fail-invalid-incremental-cluster-state-writes
branch
DaveCTurner
added a commit
that referenced
this pull request
Aug 12, 2020
It is disastrous if we commit an incremental cluster state update without having written the full state first. We assert that this doesn't happen, but it is hard to fully test the myriad ways that things might fail in a messy production environment. Given the disastrous consequences it is worth erring on the side of caution in this area. This commit fails invalid writes even if assertions are disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is disastrous if we commit an incremental cluster state update
without having written the full state first. We assert that this doesn't
happen, but it is hard to fully test the myriad ways that things might
fail in a messy production environment. Given the disastrous
consequences it is worth erring on the side of caution in this area.
This commit fails invalid writes even if assertions are disabled.