Improve benchmark tests #6225
Closed
Improve benchmark tests #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the ability to test the benchmark API by adding several features. Pause/resume: New API commands are added to pause running benchmarks and to resume them. The commands are exposed in the REST API at /_bench/(pause|resume). Control commands: Adding the pause/resume resulted in a lot of duplicate code. Consequently, this commit consolidates the code for 3 different API commands into one. The result is a new control API that handles the logic for pause, resume, and status requests. REST API has not changed for status requests. The Java API has been slightly modified to accept a control command parameter to specify pause/resume/status. Mocking: A mock service is implemented which provides the ability to pause benchmarks after they have been submitted, but before they actually start executing. This allows easy testing of various benchmark states w/o having to do tricks to coerce runtime state. Closes #6224
|
I moved this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the ability to test the benchmark API by adding
several features.
Pause/resume: New API commands are added to pause running benchmarks and
to resume them. The commands are exposed in the REST API at
/_bench/(pause|resume).
Control commands: Adding the pause/resume resulted in a lot of duplicate
code. Consequently, this commit consolidates the code for 3 different
API commands into one. The result is a new control API that handles the
logic for pause, resume, and status requests. REST API has not changed
for status requests. The Java API has been slightly modified to accept a
control command parameter to specify pause/resume/status.
Mocking: A mock service is implemented which provides the ability to
pause benchmarks after they have been submitted, but before they
actually start executing. This allows easy testing of various benchmark
states w/o having to do tricks to coerce runtime state.
Closes #6224