Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify unsigned_long tests for broader ranges #63782

Merged

Commits on Oct 15, 2020

  1. Modify unsigned_long tests for broader ranges

    UnsignedLongTests for the range agg was  using very specific intervals
    that double type can not distinguish due to lack of precision:
    
    9.223372036854776000E18 == 9.223372036854775807E18 returns true
    
    If we add the corresponding range query test, it will return different
    number of hits than the range agg, as range query unlike range agg
    doesn't convert valued to double type, and hence more precise.
    
    This patch make broader ranges for the range agg test (so values
    converted to doubles don't loose precision), and hence corresponding
    range query will return the same number of hits.
    
    Relates to elastic#60050
    mayya-sharipova committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2ec8030 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Correct formatting

    mayya-sharipova committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    91c26cb View commit details
    Browse the repository at this point in the history