Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging of terms aggregation with compound order #64469

Merged
merged 7 commits into from
Nov 5, 2020
Merged

Fix merging of terms aggregation with compound order #64469

merged 7 commits into from
Nov 5, 2020

Commits on Nov 2, 2020

  1. Fix merging of terms aggregation with compound order 

    This change fixes a bug introduced in elastic#61779 that uses a compound order to
compare buckets when merging. The bug is triggered when the compound order
uses a primary sort ordered by key (asc or desc).
This commit ensures that we always extract the primary sort when comparing keys
during merging.
The PR is marked as no-issue since the bug has not been released in any official version.
    @jimczi
    jimczi committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    faf33ed View commit details
    Browse the repository at this point in the history

  2. fix random dictionary

    @jimczi
    jimczi committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    3b0a05e View commit details
    Browse the repository at this point in the history

  3. checkstyl

    @jimczi
    jimczi committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    c684457 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Merge branch 'master' into bugs/terms_compound_order

    @jimczi
    jimczi committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f7e5eaa View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. apply review

    @jimczi
    jimczi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a1e48bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugs/terms_compound_order

    @jimczi
    jimczi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    22ae61b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. refactor tests to use a local variable

    @jimczi
    jimczi committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    3777760 View commit details
    Browse the repository at this point in the history