Mapping: Fix delete mapping race condition. #6531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple clients attempted to delete a mapping, or a single client attempted to delete a mapping as an index is being created a NPE could be observed in the MetaDataMappingService. This fix makes sure we don't try to access a null indexMetaData object. Also add a test to spawn multiple create and delete threads to provoke this race condition. Closes elastic#5997
| public void run(){ | ||
| for (int i=0; i<1000; ++i){ | ||
| try { | ||
| CreateIndexResponse cir = client().admin().indices().prepareCreate("test_index").setSource(" {\"mappings\":{" + |
There was a problem hiding this comment.
you can use assertAcked(prepareCreate(...)) here
|
|
||
| class CreateThread extends Thread{ | ||
| public void run(){ | ||
| for (int i=0; i<1000; ++i){ |
There was a problem hiding this comment.
maybe we could randomize the number of iterations and the number of threads used below?
|
Hi @GaelTadh Any progress on this one? |
|
Fixed by #7744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple clients attempted to delete a mapping, or a single client attempted to delete a mapping as an index is being
created a NPE could be observed in the MetaDataMappingService. This fix makes sure we don't try to access a null indexMetaData object.
Also add a test to spawn multiple create and delete threads to provoke this race condition.
Closes #5997