RootObjectMapper to clone the runtime fields map #65378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectMappers clone themselves as part of their merge method, and also as part of dynamic mapping updates. As part of its clone, RootObjectMapper should clone its map of runtime fields, otherwise changes to the cloned root around runtime fields are reflected in the original root, which is not desirable.
javanna
added
>non-issue
:Search/Mapping
|
Pinging @elastic/es-search (Team:Search) |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 24, 2020
ObjectMappers clone themselves as part of their merge method, and also as part of dynamic mapping updates. As part of its clone, RootObjectMapper should clone its map of runtime fields, otherwise changes to the cloned root around runtime fields are reflected in the original root, which is not desirable.
javanna
added a commit
that referenced
this pull request
Nov 24, 2020
ObjectMappers clone themselves as part of their merge method, and also as part of dynamic mapping updates. As part of its clone, RootObjectMapper should clone its map of runtime fields, otherwise changes to the cloned root around runtime fields are reflected in the original root, which is not desirable.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectMappers clone themselves as part of their merge method, and also as part of dynamic mapping updates. As part of its clone, RootObjectMapper should clone its map of runtime fields, otherwise changes to the cloned root around runtime fields are reflected in the original root, which is not desirable.