Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a consistent shard index to ShardSearchRequest (#65706) #65927

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Dec 7, 2020

Backport of #65706

* Adds a consistent shard index to ShardSearchRequest

This change ensures that the shard index that is used to tiebreak documents with identical sort
remains consistent between two requests that target the same shards. The index is now always computed from the
natural order of the shards in the search request.
This change also adds the consistent shard index to the ShardSearchRequest. That allows the slice builder
to use this information to build more balanced slice query.

Relates elastic#56828
@jimczi jimczi added the backport label Dec 7, 2020
jimczi added a commit that referenced this pull request Dec 7, 2020
This commit adapts the version check for #65706 in preparation of the backport in #65927.
The bwc tests are also disabled to not fail the build before #65927 gets merged.
@jimczi jimczi merged commit f1e8525 into elastic:7.x Dec 7, 2020
@jimczi jimczi deleted the shard_index_consistency_backport branch December 7, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant