Remove return from breakers #66943
Merged
Remove return from breakers #66943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
:Core/Infra/Circuit Breakers
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
While this is about the circuit breaker infrastructure it is really a direct follow up to #66895 so I've tagged @not-napoleon for review here. |
This removes the return values from `CircuitBreaker`'s `addEstimateBytesAndMaybeBreak` and `addWithoutBreaking` because they are not supported by the new pre-allocating `CircuitBreaker` and they aren't used for anything other than tests.
not-napoleon
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
This addresses the concern I had in #66895 but someone from Core should probably also give this at least a glance, for awareness if nothing else.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 5, 2021
This removes the return values from `CircuitBreaker`'s `addEstimateBytesAndMaybeBreak` and `addWithoutBreaking` because they are not supported by the new pre-allocating `CircuitBreaker` and they aren't used for anything other than tests.
nik9000
added a commit
that referenced
this pull request
Jan 11, 2021
This removes the return values from `CircuitBreaker`'s `addEstimateBytesAndMaybeBreak` and `addWithoutBreaking` because they are not supported by the new pre-allocating `CircuitBreaker` and they aren't used for anything other than tests. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the return values from
CircuitBreaker'saddEstimateBytesAndMaybeBreakandaddWithoutBreakingbecause theyare not supported by the new pre-allocating
CircuitBreakerand theyaren't used for anything other than tests.