Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phrase Suggester: Add option to filter out phrase suggestions #6773

Closed
wants to merge 15 commits into from
Closed

Phrase Suggester: Add option to filter out phrase suggestions #6773

wants to merge 15 commits into from

Commits on Jul 7, 2014

  1. Phrase Suggester: Add option to filter out phrase suggestions not mat… 

    …ching any documents for a given query

The newly added filter option will let the user provide a template query which will be executed for every
phrase suggestions generated to ensure that the suggestion matches at least one document for the query.
The filter query is only executed on the local node for now. When the new filter option is used, the
size of the suggestion is restricted to 20.

Closes elastic#3482
    @areek
    areek committed Jul 7, 2014
    Configuration menu
    Copy the full SHA
    535f68c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2014

  1. Incorporated Feedback

    @areek
    areek committed Jul 8, 2014
    Configuration menu
    Copy the full SHA
    f3d38df View commit details
    Browse the repository at this point in the history

  2. Use PreferenceType instead of raw strings

    @areek
    areek committed Jul 8, 2014
    Configuration menu
    Copy the full SHA
    ceac6ec View commit details
    Browse the repository at this point in the history

  3. removed unused method

    @areek
    areek committed Jul 8, 2014
    Configuration menu
    Copy the full SHA
    2693624 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2014

  1. incorporated feedback; added more tests; changed filter to collate in… 

    … API; Added support for accepting filters and template params
    @areek
    areek committed Jul 10, 2014
    Configuration menu
    Copy the full SHA
    6181d83 View commit details
    Browse the repository at this point in the history

  2. minor change in comments; remove redundant code

    @areek
    areek committed Jul 10, 2014
    Configuration menu
    Copy the full SHA
    902763b View commit details
    Browse the repository at this point in the history

  3. remove unused imports

    @areek
    areek committed Jul 10, 2014
    Configuration menu
    Copy the full SHA
    be328f8 View commit details
    Browse the repository at this point in the history

  4. remove unused imports; restore to default

    @areek
    areek committed Jul 10, 2014
    Configuration menu
    Copy the full SHA
    b4533aa View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2014

  1. incorporated feedback; added tests; minor changes in exception msgs

    @areek
    areek committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    0d7cafe View commit details
    Browse the repository at this point in the history

  2. minor change to fix asciidoc

    @areek
    areek committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    359691d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2014

  1. fix Preference enum

    @areek
    areek committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    f23712e View commit details
    Browse the repository at this point in the history

  2. Removed Preference.parseValue

    @areek
    areek committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    d6e1f07 View commit details
    Browse the repository at this point in the history

  3. minor fix

    @areek
    areek committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    5df71bb View commit details
    Browse the repository at this point in the history

  4. minor fix

    @areek
    areek committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    b4a905d View commit details
    Browse the repository at this point in the history

  5. minor fix

    @areek
    areek committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    beea2ab View commit details
    Browse the repository at this point in the history