Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid async cache-size fetch on partial shards #68644

Conversation

DaveCTurner
Copy link
Contributor

Today we perform an async fetch for every searchable snapshot shard
while allocating it, so that we can prefer to allocate it to the node
that holds the warmest cache for that shard. For partial shards, there
is no persistently-cached data to reuse, so we can skip the async fetch.

Today we perform an async fetch for every searchable snapshot shard
while allocating it, so that we can prefer to allocate it to the node
that holds the warmest cache for that shard. For partial shards, there
is no persistently-cached data to reuse, so we can skip the async fetch.
@DaveCTurner DaveCTurner added >enhancement :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.12.0 labels Feb 8, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Feb 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 256b838 into elastic:master Feb 8, 2021
@DaveCTurner
Copy link
Contributor Author

Thanks @tlrx

@DaveCTurner DaveCTurner deleted the 2021-02-08-no-fetch-for-partial-shards branch February 8, 2021 11:52
DaveCTurner added a commit that referenced this pull request Feb 8, 2021
Today we perform an async fetch for every searchable snapshot shard
while allocating it, so that we can prefer to allocate it to the node
that holds the warmest cache for that shard. For partial shards, there
is no persistently-cached data to reuse, so we can skip the async fetch.
easyice pushed a commit to easyice/elasticsearch that referenced this pull request Mar 25, 2021
Today we perform an async fetch for every searchable snapshot shard
while allocating it, so that we can prefer to allocate it to the node
that holds the warmest cache for that shard. For partial shards, there
is no persistently-cached data to reuse, so we can skip the async fetch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement Team:Distributed Meta label for distributed team v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants