Fix position increment gap on phrase/prefix analyzers #70096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>bug
:Search/Analysis
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticmachine run elasticsearch-ci/rest-compat |
romseygeek
added a commit
that referenced
this pull request
Mar 9, 2021
Custom position increments are handled by wrapping analyzers with a NamedAnalyzer and passing the custom increment through to its constructor. However, phrase and prefix analyzers use delegating analyzer wrappers to add extra filtering to their parent analyzers, and we can't wrap analyzers multiple times because this wrecks reuse strategies, so we unwrap the parent before passing it to phrase and prefix builders. This unwrapping means that we lose the custom position increments; in particular, it means that we can end up with a position increment gap of -1, which is the sentinel value for the unset parameter - and that means exceptions at index time for backwards-moving positions on fields with multiple values. This commit removes the sentinel value and uses standard parameter defaults and the isConfigured() method instead, plus it adds some more comprehensive testing for position increments when combined with phrase/prefix index options on text fields. Fixes #70049
romseygeek
added a commit
that referenced
this pull request
Mar 9, 2021
Custom position increments are handled by wrapping analyzers with a NamedAnalyzer and passing the custom increment through to its constructor. However, phrase and prefix analyzers use delegating analyzer wrappers to add extra filtering to their parent analyzers, and we can't wrap analyzers multiple times because this wrecks reuse strategies, so we unwrap the parent before passing it to phrase and prefix builders. This unwrapping means that we lose the custom position increments; in particular, it means that we can end up with a position increment gap of -1, which is the sentinel value for the unset parameter - and that means exceptions at index time for backwards-moving positions on fields with multiple values. This commit removes the sentinel value and uses standard parameter defaults and the isConfigured() method instead, plus it adds some more comprehensive testing for position increments when combined with phrase/prefix index options on text fields. Fixes #70049
easyice
pushed a commit
to easyice/elasticsearch
that referenced
this pull request
Mar 25, 2021
Custom position increments are handled by wrapping analyzers with a NamedAnalyzer and passing the custom increment through to its constructor. However, phrase and prefix analyzers use delegating analyzer wrappers to add extra filtering to their parent analyzers, and we can't wrap analyzers multiple times because this wrecks reuse strategies, so we unwrap the parent before passing it to phrase and prefix builders. This unwrapping means that we lose the custom position increments; in particular, it means that we can end up with a position increment gap of -1, which is the sentinel value for the unset parameter - and that means exceptions at index time for backwards-moving positions on fields with multiple values. This commit removes the sentinel value and uses standard parameter defaults and the isConfigured() method instead, plus it adds some more comprehensive testing for position increments when combined with phrase/prefix index options on text fields. Fixes elastic#70049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom position increments are handled by wrapping analyzers
with a NamedAnalyzer and passing the custom increment through
to its constructor. However, phrase and prefix analyzers use
delegating analyzer wrappers to add extra filtering to their parent
analyzers, and we can't wrap analyzers multiple times because this
wrecks reuse strategies, so we unwrap the parent before passing
it to phrase and prefix builders. This unwrapping means that we
lose the custom position increments; in particular, it means that
we can end up with a position increment gap of -1, which is the
sentinel value for the unset parameter - and that means exceptions
at index time for backwards-moving positions on fields with multiple
values.
This commit removes the sentinel value and uses standard parameter
defaults and the
isConfigured()method instead, plus it adds somemore comprehensive testing for position increments when combined
with phrase/prefix index options on text fields.
Fixes #70049