SQL: Removed the always on total hit tracking #70319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the query uses `COUNT(*)` the total hits are automatically tracked: https://github.com/elastic/elasticsearch/blob/a92a647b9f17d1bddf5c707490a19482c273eda3/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java#L639 Otherwise the `track_total_hits` is only useful for scrolling. If the query is translated to (https://github.com/elastic/elasticsearch/blob/ee5cc5442a8e01d7d8fa426748d0b086959bf99d/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java#L130): - a scroll query (all the non-agg only queries), ES will automatically provide accurate total hits without us having to flip the `track_total_hits` - agg-only query: implicit group by (result is single record) or composite aggregation. `track_total_hits` does not affect these queries, it can only affect document search hits Closes elastic#52787
palesz
added
>enhancement
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
approved these changes
Mar 15, 2021
palesz
pushed a commit
to palesz/elasticsearch
that referenced
this pull request
Mar 15, 2021
If the query uses `COUNT(*)` the total hits are automatically tracked: https://github.com/elastic/elasticsearch/blob/a92a647b9f17d1bddf5c707490a19482c273eda3/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java#L639 Otherwise, the `track_total_hits` is only useful for scrolling. If the query is translated to: - a scroll query (all the non-agg only queries), ES will automatically provide accurate total hits without us having to flip the `track_total_hits` - agg-only query, the `track_total_hits` does not affect these queries (implicit group by (result is single record) or composite aggregation), it can only affect document search hits See translation at: https://github.com/elastic/elasticsearch/blob/ee5cc5442a8e01d7d8fa426748d0b086959bf99d/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java#L130 Closes elastic#52787
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 15, 2021
If the query uses `COUNT(*)` the total hits are automatically tracked: https://github.com/elastic/elasticsearch/blob/a92a647b9f17d1bddf5c707490a19482c273eda3/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java#L639 Otherwise, the `track_total_hits` is only useful for scrolling. If the query is translated to: - a scroll query (all the non-agg only queries), ES will automatically provide accurate total hits without us having to flip the `track_total_hits` - agg-only query, the `track_total_hits` does not affect these queries (implicit group by (result is single record) or composite aggregation), it can only affect document search hits See translation at: https://github.com/elastic/elasticsearch/blob/ee5cc5442a8e01d7d8fa426748d0b086959bf99d/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java#L130 Closes elastic#52787
palesz
pushed a commit
that referenced
this pull request
Mar 16, 2021
If the query uses `COUNT(*)` the total hits are automatically tracked: https://github.com/elastic/elasticsearch/blob/a92a647b9f17d1bddf5c707490a19482c273eda3/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java#L639 Otherwise, the `track_total_hits` is only useful for scrolling. If the query is translated to: - a scroll query (all the non-agg only queries), ES will automatically provide accurate total hits without us having to flip the `track_total_hits` - agg-only query, the `track_total_hits` does not affect these queries (implicit group by (result is single record) or composite aggregation), it can only affect document search hits See translation at: https://github.com/elastic/elasticsearch/blob/ee5cc5442a8e01d7d8fa426748d0b086959bf99d/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java#L130 Closes #52787
easyice
pushed a commit
to easyice/elasticsearch
that referenced
this pull request
Mar 25, 2021
If the query uses `COUNT(*)` the total hits are automatically tracked: https://github.com/elastic/elasticsearch/blob/a92a647b9f17d1bddf5c707490a19482c273eda3/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java#L639 Otherwise, the `track_total_hits` is only useful for scrolling. If the query is translated to: - a scroll query (all the non-agg only queries), ES will automatically provide accurate total hits without us having to flip the `track_total_hits` - agg-only query, the `track_total_hits` does not affect these queries (implicit group by (result is single record) or composite aggregation), it can only affect document search hits See translation at: https://github.com/elastic/elasticsearch/blob/ee5cc5442a8e01d7d8fa426748d0b086959bf99d/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java#L130 Closes elastic#52787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the query uses
COUNT(*)the total hits are automatically tracked:elasticsearch/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/planner/QueryFolder.java
Line 639 in a92a647
Otherwise the
track_total_hitsis only useful for scrolling.If the query is translated to:
without us having to flip the
track_total_hitstrack_total_hitsdoes not affect these queries, it can only affect document search hitselasticsearch/x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/execution/search/Querier.java
Line 130 in ee5cc54
Closes #52787