[ML] Consider xpack.ml.max_ml_node_size in effective_model_memory_limit #70473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the calculation of effective_model_memory_limit in the _ml/info response to take account of xpack.ml.max_ml_node_size if it is set and xpack.ml.max_lazy_ml_nodes would allow more ML nodes to be added to the cluster. The assumption is that if necessary the size of the newly added nodes would be xpack.ml.max_ml_node_size, so it's reasonable for newly created jobs to have a model_memory_limit that would fit on a node of that size. Fixes elastic#70069
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
approved these changes
Mar 16, 2021
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Mar 17, 2021
Changes the calculation of effective_model_memory_limit in the _ml/info response to take account of xpack.ml.max_ml_node_size if it is set and xpack.ml.max_lazy_ml_nodes would allow more ML nodes to be added to the cluster. The assumption is that if necessary the size of the newly added nodes would be xpack.ml.max_ml_node_size, so it's reasonable for newly created jobs to have a model_memory_limit that would fit on a node of that size. Backport of elastic#70473
droberts195
added a commit
that referenced
this pull request
Mar 17, 2021
…it (#70484) Changes the calculation of effective_model_memory_limit in the _ml/info response to take account of xpack.ml.max_ml_node_size if it is set and xpack.ml.max_lazy_ml_nodes would allow more ML nodes to be added to the cluster. The assumption is that if necessary the size of the newly added nodes would be xpack.ml.max_ml_node_size, so it's reasonable for newly created jobs to have a model_memory_limit that would fit on a node of that size. Backport of #70473
easyice
pushed a commit
to easyice/elasticsearch
that referenced
this pull request
Mar 25, 2021
…it (elastic#70473) Changes the calculation of effective_model_memory_limit in the _ml/info response to take account of xpack.ml.max_ml_node_size if it is set and xpack.ml.max_lazy_ml_nodes would allow more ML nodes to be added to the cluster. The assumption is that if necessary the size of the newly added nodes would be xpack.ml.max_ml_node_size, so it's reasonable for newly created jobs to have a model_memory_limit that would fit on a node of that size. Fixes elastic#70069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the calculation of effective_model_memory_limit in the
_ml/info response to take account of xpack.ml.max_ml_node_size
if it is set and xpack.ml.max_lazy_ml_nodes would allow more
ML nodes to be added to the cluster. The assumption is that
if necessary the size of the newly added nodes would be
xpack.ml.max_ml_node_size, so it's reasonable for newly created
jobs to have a model_memory_limit that would fit on a node of
that size.
Fixes #70069