Don't throw DAEE on replica for create operation; use IW.updateDocument/s instead #7146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that now a replica by definition should not throw a DAEE, we should remove it from |
|
Oh that's great, I'll remove exemption of DAEE from there. |
|
OK I removed DAEE from exemption list; I'll commit & close shortly... |
mikemccand
added a commit
that referenced
this pull request
Aug 4, 2014
…nconsistent replica If simultaneous create & delete operations arrive against the same id, it's possible that primary and replica see those operations in different orders, which may result in replica throwing DocumentAlreadyExistsException when the primary didn't which would lead to replica being inconsistent (missing a document that primary had indexed). This push fixes the issue, by never throwing DAEE from the replica on create. Closes #7146 #7142
mikemccand
added a commit
that referenced
this pull request
Aug 6, 2014
…nconsistent replica If simultaneous create & delete operations arrive against the same id, it's possible that primary and replica see those operations in different orders, which may result in replica throwing DocumentAlreadyExistsException when the primary didn't which would lead to replica being inconsistent (missing a document that primary had indexed). This push fixes the issue, by never throwing DAEE from the replica on create. Closes #7146 #7142
mikemccand
added a commit
that referenced
this pull request
Sep 8, 2014
…nconsistent replica If simultaneous create & delete operations arrive against the same id, it's possible that primary and replica see those operations in different orders, which may result in replica throwing DocumentAlreadyExistsException when the primary didn't which would lead to replica being inconsistent (missing a document that primary had indexed). This push fixes the issue, by never throwing DAEE from the replica on create. Closes #7146 #7142
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
the
:Distributed/CRUD
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…nconsistent replica If simultaneous create & delete operations arrive against the same id, it's possible that primary and replica see those operations in different orders, which may result in replica throwing DocumentAlreadyExistsException when the primary didn't which would lead to replica being inconsistent (missing a document that primary had indexed). This push fixes the issue, by never throwing DAEE from the replica on create. Closes elastic#7146 elastic#7142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #7142: if we are on a replica doing a create, instead of throwing DAEE when the doc is in the index with an older version, we just call IW.updateDocument/s, because the primary already "decided" the document should be indexed.