Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MavenFilteringHack, Groovy to Java #72058

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Convert MavenFilteringHack, Groovy to Java #72058

merged 4 commits into from
Apr 26, 2021

Conversation

edh-oss
Copy link
Contributor

@edh-oss edh-oss commented Apr 22, 2021

Port to Java, related to issue #34459

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Apr 22, 2021
@breskeby breskeby self-assigned this Apr 22, 2021
@breskeby breskeby added the :Delivery/Build Build or test infrastructure label Apr 22, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Apr 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby
Copy link
Contributor

@elasticsearchmachine test this please

Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

thanks for your contribution. There's a minor issue with your changes that breaks the build when passing non String values to the MavenFilteringHack.

If you are able to fix this we can merge this PR

@breskeby
Copy link
Contributor

@elasticmachine test this please

@breskeby
Copy link
Contributor

@elasticmachine test this please

@breskeby breskeby merged commit 8e0506c into elastic:master Apr 26, 2021
@breskeby
Copy link
Contributor

@edh-oss I've merged your PR. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Delivery Meta label for Delivery team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants