Convert AntTask from Groovy to Java #72506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
external-contributor
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine test this please |
|
The details are no longer available, but I did look at them earlier this week. My impression was that the two failing checks appeared to be failing for reasons unrelated to the changes in this CR. Can we try the tests again? |
|
@elasticmachine test this please |
|
@edh-oss can you please rebase your branch against latest master please? |
|
Sure. Done. |
|
Rebased against the latest master. Can we test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #34459