Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Data stream snapshot behavior with excluded backing indices #72761

Merged

Conversation

danhermann
Copy link
Contributor

Relates to #72747

@danhermann danhermann added >docs General docs changes v8.0.0 :Data Management/Data streams Data streams and their lifecycles v7.14.0 v7.13.1 labels May 5, 2021
@danhermann danhermann requested a review from jrodewig May 5, 2021 16:00
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels May 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a wording suggestion, but feel free to ignore if wanted. Thanks @danhermann.

Comment on lines 65 to 70
metadata or its other backing indices. Snapshots can also include data streams
but exclude specific backing indices. In this case, the data stream will be
restored with only the backing indices present in the snapshot. In the case
that the original write index of the data stream was not present in the
snapshot, the data stream's most recent backing index that is present in the
snapshot will become the current write index.
Copy link
Contributor

@jrodewig jrodewig May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd break this into a separate paragraph and reword to avoid passive voice. Feel free to ignore if wanted.

Suggested change
metadata or its other backing indices. Snapshots can also include data streams
but exclude specific backing indices. In this case, the data stream will be
restored with only the backing indices present in the snapshot. In the case
that the original write index of the data stream was not present in the
snapshot, the data stream's most recent backing index that is present in the
snapshot will become the current write index.
metadata or its other backing indices.
Snapshots can also include a data stream but exclude specific backing indices.
When you restore the data stream, it will only contain backing indices present
in the snapshot. If the stream's original write index is not in the snapshot,
the most recent backing index from the snapshot becomes the stream's write index.

@danhermann danhermann merged commit 3c08d82 into elastic:master May 6, 2021
@danhermann danhermann deleted the document_data_stream_snapshot_behavior branch May 6, 2021 12:35
@danhermann
Copy link
Contributor Author

Thanks, @jrodewig! I included your suggested wording in the commit.

chengyang14 pushed a commit to chengyang14/elasticsearch that referenced this pull request May 7, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Jun 30, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Jul 6, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.13.0 v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants