Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLRC] change GET method to POST in Searchtemplate #72851

Merged
merged 1 commit into from May 11, 2021
Merged

[HLRC] change GET method to POST in Searchtemplate #72851

merged 1 commit into from May 11, 2021

Conversation

chengyang14
Copy link
Contributor

@chengyang14 chengyang14 commented May 7, 2021 •
edited

Fix #72073
Close #72397

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 7, 2021
@chengyang14
Copy link
Contributor Author

@dakrone please help review this

@dakrone dakrone self-requested a review May 10, 2021 15:18
@dakrone
Copy link
Member

dakrone commented May 10, 2021

@elasticmachine ok to test

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

dakrone
dakrone approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chengyang14

@dakrone dakrone changed the title [HLRC]change get method to post in Searchtemplate [HLRC] change GET method to POST in Searchtemplate May 11, 2021
@dakrone dakrone merged commit d33d41d into elastic:master May 11, 2021
@dakrone dakrone mentioned this pull request May 11, 2021
Merged
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request May 11, 2021
@chengyang14 @dakrone
[HLRC] change GET method to POST in Searchtemplate (elastic#72851)
a71f3af 
Fix elastic#72073
Close elastic#72397
dakrone added a commit that referenced this pull request May 11, 2021
@dakrone @chengyang14
[7.x] [HLRC] change GET method to POST in Searchtemplate (#72851) (d3…
872211c 
…3d41d) (#72932)

Fix #72073
Close #72397

Co-authored-by: Yang Cheng <chengyang2048@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v7.14.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

searchTemplate method doing a GET instead of a POST
6 participants
@chengyang14 @dakrone @elasticmachine @jakelandis @probakowski @elasticsearchmachine