Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Move won't fix tests from block list #73912

Merged
merged 5 commits into from
Jun 14, 2021
Merged

[Rest Api Compatibility] Move won't fix tests from block list #73912

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63c85d4
extract tests that won't be fixed
pgomulka Jun 8, 2021
c8ac8e4
cat and rename
pgomulka Jun 9, 2021
0bef11f
fix regex
pgomulka Jun 9, 2021
8162a41
tweak regex
pgomulka Jun 9, 2021
a15d304
Merge remote-tracking branch 'upstream/master' into compat/extract_wo…
pgomulka Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
126 changes: 37 additions & 89 deletions rest-api-spec/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,100 +28,47 @@ testClusters.all {

tasks.named("test").configure { enabled = false }
tasks.named("jarHell").configure { enabled = false }

def v7compatiblityNotSupportedTests = {
return [
// Cat API are meant to be consumed by humans, so will not be supported by Compatible REST API
'cat*/*/*',
// type information about the type is removed and not passed down. The logic to check for this is also removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we cleanup/remove some of these comments then given we don't plan on addressing any of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those are beneficial. It is good to know the reason why the test is disabled without actually reading the test. The reasoning why it is disabled is clear now, but after a month or two (or earlier :D ) we might forget the details

'delete/70_mix_typeless_typeful/DELETE with typeless API on an index that has types',
// WILL NOT BE FIXED - failing due to not recognising missing type (the type path param is ignored)
'get/100_mix_typeless_typeful/GET with typeless API on an index that has types',
// type information about the type is removed and not passed down. The logic to check for this is also removed.
'indices.create/20_mix_typeless_typeful/Implicitly create a typed index while there is a typeless template',
'indices.create/20_mix_typeless_typeful/Implicitly create a typeless index while there is a typed template',
//
// This test returns test_index.mappings:{} when {} was expected. difference between 20_missing_field and 21_missing_field_with_types?
'indices.get_field_mapping/21_missing_field_with_types/Return empty object if field doesn\'t exist, but type and index do',
// The information about the type is not present in the index. hence it cannot know if the type exist or not.
'indices.get_field_mapping/30_missing_type/Raise 404 when type doesn\'t exist',
// The information about the type is not present in the index. hence it cannot know if the type exist or not.
'indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type',
'indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type',
'indices.get_mapping/20_missing_type/No type matching pattern returns 404',
'indices.get_mapping/20_missing_type/Non-existent type returns 404',
'indices.get_mapping/20_missing_type/Type missing when no types exist',
//
// The information about the type is not present in the index. hence it cannot know if the type was already used or not
'indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types',
'indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types',
// there is a small distinction between empty mappings and no mappings at all. The code to implement this test was refactored #54003
// field search on _type field- not implementing. The data for _type is considered incorrect in this search
'search/160_exists_query/Test exists query on _type field',
//type information is not stored, hence the the index will be found
'termvectors/50_mix_typeless_typeful/Term vectors with typeless API on an index that has types',
// 85 - 13 = 72 tests won't be fixed
]
}
tasks.named("yamlRestCompatTest").configure {
onlyIf {
// Skip these tests on Windows since the blacklist exceeds Windows CLI limits
OS.current() != OS.WINDOWS
}

systemProperty 'tests.rest.blacklist', [
'cat.aliases/10_basic/Alias against closed index',
'cat.aliases/10_basic/Alias name',
'cat.aliases/10_basic/Alias sorting',
'cat.aliases/10_basic/Column headers',
'cat.aliases/10_basic/Complex alias',
'cat.aliases/10_basic/Empty cluster',
'cat.aliases/10_basic/Multiple alias names',
'cat.aliases/10_basic/Select columns',
'cat.aliases/10_basic/Simple alias',
'cat.aliases/40_hidden/Test cat aliases output with a hidden index with a hidden alias',
'cat.aliases/40_hidden/Test cat aliases output with a hidden index with a visible alias',
'cat.aliases/40_hidden/Test cat aliases output with a visible index with a hidden alias',
'cat.allocation/10_basic/All Nodes',
'cat.allocation/10_basic/Bytes',
'cat.allocation/10_basic/Column headers',
'cat.allocation/10_basic/Empty cluster',
'cat.allocation/10_basic/Node ID',
'cat.allocation/10_basic/One index',
'cat.allocation/10_basic/Select columns',
'cat.count/10_basic/Test cat count output',
'cat.fielddata/10_basic/Test cat fielddata output',
'cat.health/10_basic/Empty cluster',
'cat.health/10_basic/With ts parameter',
'cat.indices/10_basic/Test cat indices output',
'cat.indices/10_basic/Test cat indices output (no indices)',
'cat.indices/10_basic/Test cat indices output for closed index',
'cat.indices/10_basic/Test cat indices sort',
'cat.indices/10_basic/Test cat indices using health status',
'cat.indices/10_basic/Test cat indices using wildcards',
'cat.indices/20_hidden/Test cat indices output for dot-hidden index and dot-prefixed pattern',
'cat.indices/20_hidden/Test cat indices output for hidden index',
'cat.indices/20_hidden/Test cat indices output with a hidden index with a hidden alias',
'cat.indices/20_hidden/Test cat indices output with a hidden index with a visible alias',
'cat.indices/20_hidden/Test cat indices output with a hidden index, dot-hidden alias and dot pattern',
'cat.nodeattrs/10_basic/Test cat nodes attrs output',
'cat.nodes/10_basic/Additional disk information',
'cat.nodes/10_basic/Test cat nodes output',
'cat.nodes/10_basic/Test cat nodes output with full_id set',
'cat.recovery/10_basic/Test cat recovery output',
'cat.recovery/10_basic/Test cat recovery output for closed index',
'cat.repositories/10_basic/Test cat repositories output',
'cat.repositories/10_basic/Test cat repositories sort',
'cat.segments/10_basic/Test cat segments output',
'cat.segments/10_basic/Test cat segments using wildcards',
'cat.shards/10_basic/Help',
'cat.shards/10_basic/Test cat shards output',
'cat.shards/10_basic/Test cat shards sort',
'cat.shards/10_basic/Test cat shards using wildcards',
'cat.snapshots/10_basic/Help',
'cat.snapshots/10_basic/Test cat snapshots output',
'cat.tasks/10_basic/Test cat tasks output',
'cat.tasks/10_basic/Test cat tasks output with X-Opaque-Id',
'cat.templates/10_basic/Column headers',
'cat.templates/10_basic/Filtered templates',
'cat.templates/10_basic/Mixture of legacy and composable templates',
'cat.templates/10_basic/Normal templates',
'cat.templates/10_basic/Select columns',
'cat.thread_pool/10_basic/Test cat thread_pool output',
// type information about the type is removed and not passed down. The logic to check for this is also removed.
'delete/70_mix_typeless_typeful/DELETE with typeless API on an index that has types',
// WILL NOT BE FIXED - failing due to not recognising missing type (the type path param is ignored)
'get/100_mix_typeless_typeful/GET with typeless API on an index that has types',
// type information about the type is removed and not passed down. The logic to check for this is also removed.
'indices.create/20_mix_typeless_typeful/Implicitly create a typed index while there is a typeless template',
'indices.create/20_mix_typeless_typeful/Implicitly create a typeless index while there is a typed template',
//
// This test returns test_index.mappings:{} when {} was expected. difference between 20_missing_field and 21_missing_field_with_types?
'indices.get_field_mapping/21_missing_field_with_types/Return empty object if field doesn\'t exist, but type and index do',
// The information about the type is not present in the index. hence it cannot know if the type exist or not.
'indices.get_field_mapping/30_missing_type/Raise 404 when type doesn\'t exist',
// The information about the type is not present in the index. hence it cannot know if the type exist or not.
'indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type',
'indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type',
'indices.get_mapping/20_missing_type/No type matching pattern returns 404',
'indices.get_mapping/20_missing_type/Non-existent type returns 404',
'indices.get_mapping/20_missing_type/Type missing when no types exist',
//
// The information about the type is not present in the index. hence it cannot know if the type was already used or not
'indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types',
'indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types',
// there is a small distinction between empty mappings and no mappings at all. The code to implement this test was refactored #54003
// field search on _type field- not implementing. The data for _type is considered incorrect in this search
'search/160_exists_query/Test exists query on _type field',
//type information is not stored, hence the the index will be found
'termvectors/50_mix_typeless_typeful/Term vectors with typeless API on an index that has types',
// 85 - 13 = 72 tests won't be fixed
systemProperty 'tests.rest.blacklist', ([
'cluster.voting_config_exclusions/10_basic/Throw exception when adding voting config exclusion and specifying both node_ids and node_names',
'cluster.voting_config_exclusions/10_basic/Throw exception when adding voting config exclusion without specifying nodes',
'count/11_basic_with_types/count body without query element',
Expand Down Expand Up @@ -210,7 +157,8 @@ tasks.named("yamlRestCompatTest").configure {
'snapshot.get/10_basic/Get snapshot info with metadata',
'snapshot.get/10_basic/Get snapshot info with index details',
'suggest/20_completion/Suggestions with source should work'
].join(',')
] + v7compatiblityNotSupportedTests())
.join(',')
}

tasks.named("transformV7RestTests").configure({ task ->
Expand Down