Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared cache's recovery range should be aligned with page size #74439

Merged
merged 1 commit into from Jun 23, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jun 22, 2021

Shared cache expects read and write operations to be aligned with a given page size (4096 bytes). The recovery range size setting should be validated against this constraint and the integration tests should not try to set a non-aligned setting value.

Closes #74372

@tlrx tlrx added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.14.0 v7.13.3 labels Jun 22, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jun 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tlrx tlrx merged commit 983c5db into elastic:master Jun 23, 2021
@tlrx tlrx deleted the align-recovery-range-frozen branch June 23, 2021 09:19
@tlrx
Copy link
Member Author

tlrx commented Jun 23, 2021

Thanks Henning

tlrx added a commit to tlrx/elasticsearch that referenced this pull request Jun 23, 2021
…ic#74439)

Shared cache expects read and write operations to be aligned 
with a given page size (4096 bytes). The recovery range size 
setting should be validated against this constraint and the 
integration tests should not try to set a non-aligned setting 
value.

Closes elastic#74372
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Jun 23, 2021
…ic#74439)

Shared cache expects read and write operations to be aligned 
with a given page size (4096 bytes). The recovery range size 
setting should be validated against this constraint and the 
integration tests should not try to set a non-aligned setting 
value.

Closes elastic#74372
tlrx added a commit that referenced this pull request Jun 23, 2021
…#74471)

Shared cache expects read and write operations to be aligned 
with a given page size (4096 bytes). The recovery range size 
setting should be validated against this constraint and the 
integration tests should not try to set a non-aligned setting 
value.

Backport of #74439
Closes #74372
tlrx added a commit that referenced this pull request Jun 23, 2021
…#74474)

Shared cache expects read and write operations to be aligned 
with a given page size (4096 bytes). The recovery range size 
setting should be validated against this constraint and the 
integration tests should not try to set a non-aligned setting 
value.

Backport of #74439
Closes #74372
csoulios pushed a commit to csoulios/elasticsearch that referenced this pull request Jun 24, 2021
…ic#74439)

Shared cache expects read and write operations to be aligned 
with a given page size (4096 bytes). The recovery range size 
setting should be validated against this constraint and the 
integration tests should not try to set a non-aligned setting 
value.

Closes elastic#74372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team v7.13.3 v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] FrozenSearchableSnapshotsIntegTests testCreateAndRestorePartialSearchableSnapshot failing
4 participants