New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared cache's recovery range should be aligned with page size #74439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.14.0
v7.13.3
labels
Jun 22, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks Henning |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 23, 2021
…ic#74439) Shared cache expects read and write operations to be aligned with a given page size (4096 bytes). The recovery range size setting should be validated against this constraint and the integration tests should not try to set a non-aligned setting value. Closes elastic#74372
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 23, 2021
…ic#74439) Shared cache expects read and write operations to be aligned with a given page size (4096 bytes). The recovery range size setting should be validated against this constraint and the integration tests should not try to set a non-aligned setting value. Closes elastic#74372
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Jun 24, 2021
…ic#74439) Shared cache expects read and write operations to be aligned with a given page size (4096 bytes). The recovery range size setting should be validated against this constraint and the integration tests should not try to set a non-aligned setting value. Closes elastic#74372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed
Meta label for distributed team
v7.13.3
v7.14.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared cache expects read and write operations to be aligned with a given page size (4096 bytes). The recovery range size setting should be validated against this constraint and the integration tests should not try to set a non-aligned setting value.
Closes #74372