New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IndicesOptions.fromOptions (#30663) #74597
base: main
Are you sure you want to change the base?
Remove IndicesOptions.fromOptions (#30663) #74597
Conversation
PedroDMonteiro
commented
Jun 27, 2021
•
edited
edited
- Transform fromOptions() methods into constructors
- Refres to issue Remove IndicesOptions.fromOptions #30663
Pinging @elastic/es-core-features (Team:Core/Features) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea proposed in #30663 is more along the lines of what is mentioned in this comment: https://github.com/elastic/elasticsearch/pull/30586/files#r188111416
since replacing fromOptions(boolean, boolean, ...)
with a constructor IndicesOptions(boolean, boolean, ...)
doesn't really reduce the "trappy-ness" of the API.
Pinging @elastic/es-data-management (Team:Data Management) |