Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] autoscaling context current capacity could be null, this commit handles that #74822

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Jul 1, 2021

context commit may be null. This should only really happen early in a cluster's life cycle or if a node was just recently brought online. Mainly because the current node sizes have not been discovered yet and cached.

This change should really have been part of #74691 and was incorporated into the backports of that PR, which is the reason why this PR only needs to go into master.

@benwtrent benwtrent added >non-issue :ml Machine learning v8.0.0 labels Jul 1, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I changed the description to indicate why this doesn't need backporting.

@benwtrent benwtrent merged commit c8c4200 into elastic:master Jul 1, 2021
@benwtrent benwtrent deleted the feature/ml-handle-null-current-capacity-autoscaling branch July 1, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants