Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Do not return _doc for empty mappings in template #75448

Merged
merged 1 commit into from Jul 19, 2021
Merged

[Rest Api Compatibility] Do not return _doc for empty mappings in template #75448

merged 1 commit into from Jul 19, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 19, 2021 •
edited

Previously the compatibility layer was always returning an _doc in mappings for get
template.
This commit does not return _doc in empty mappings.
Returning just {} empty object (v7 and v8 behaviour)

also moving term lookups tests which are already fixed (relates #74544)

relates #70966
relates main meta issue #51816
relates types removal meta #54160

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Do not return _doc for empty mappings in tem…
d3325de 
…plate

Previously the compatibility layer was alwayre returning an _doc for get
template.
This commit does not return _doc in mappings when mappings are empty.
Returning just {} empty object

also moving term lookups tests which are already fixed (relates elastic#74544)

relates elastic#70966
relates main meta issue elastic#51816
relates types removal meta elastic#54160
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jul 19, 2021
@pgomulka pgomulka self-assigned this Jul 19, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from romseygeek July 19, 2021 11:14
romseygeek
romseygeek approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricksy! LGTM.

@pgomulka pgomulka merged commit 5485d3e into elastic:master Jul 19, 2021
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@pgomulka @ywangd
[Rest Api Compatibility] Do not return _doc for empty mappings in tem…
38f6db9 
…plate (elastic#75448)

Previously the compatibility layer was always returning an _doc in mappings for get
template.
This commit does not return _doc in empty mappings.
Returning just {} empty object (v7 and v8 behaviour)

also moving term lookups tests which are already fixed (relates elastic#74544)

relates elastic#70966
relates main meta issue elastic#51816
relates types removal meta elastic#54160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

@pgomulka pgomulka

Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis