Search performance - better caching logic for queries on wildcard field #76035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
markharwood
force-pushed
the
fix/75848
branch
2 times, most recently
from
a6d6c41
to
36d7a5b
Compare
jtibshirani
reviewed
Aug 3, 2021
...src/main/java/org/elasticsearch/xpack/wildcard/mapper/ApproximationAndVerificationQuery.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/wildcard/mapper/ApproximationAndVerificationQuery.java
Outdated
Show resolved
Hide resolved
jtibshirani
reviewed
Aug 5, 2021
...d/src/main/java/org/elasticsearch/xpack/wildcard/mapper/BinaryDvConfirmedAutomatonQuery.java
Outdated
Show resolved
Hide resolved
...d/src/main/java/org/elasticsearch/xpack/wildcard/mapper/BinaryDvConfirmedAutomatonQuery.java
Show resolved
Hide resolved
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
…nning contained verification query clauses across whole index at great expense. The new ApproximationAndVerificationQuery provides a replacement wrapper that plays better with caching logic Closes elastic#75848
…Query which contains both the approximation (ngram index) query for acceleration and the automaton DV query.
jtibshirani
approved these changes
Aug 5, 2021
jtibshirani
reviewed
Aug 5, 2021
| // Bug if we have an indexed value but no doc value. | ||
| assert false; | ||
| // Bug if we have an indexed value (i.e an approxQuery) but no doc value. | ||
| assert approxQuery instanceof MatchAllDocsQuery == false; |
There was a problem hiding this comment.
Can you explain why this assertion changed? The original version seemed correct to me.
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Aug 9, 2021
…ld (elastic#76035) Remove use of BooleanQuery to prevent query caching framework from running contained verification query clauses across whole index at great expense. The new BinaryDVConfirmedAutomatonQuery provides a replacement wrapper that plays better with caching logic Closes elastic#75848
markharwood
added a commit
that referenced
this pull request
Aug 9, 2021
…ld (#76035) (#76182) Backport to remove use of BooleanQuery to prevent query caching framework from running contained verification query clauses across whole index at great expense. The new BinaryDVConfirmedAutomatonQuery provides a replacement wrapper that plays better with caching logic Closes #75848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of BooleanQuery in WildcardField regex/wildcard/fuzzy/prefix searches to prevent query caching framework from running the contained verification query clauses across whole index at great expense.
The new BinaryDvConfirmedAutomatonQuery provides a replacement wrapper for the approximation and verification clauses that plays better with caching logic
Closes #75848