Fix compiler warnings in :server - part 4 #76302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Aug 10, 2021
| @@ -85,10 +85,6 @@ dependencies { | |||
|
|
|||
| } | |||
|
|
|||
| tasks.withType(JavaCompile).configureEach { | |||
| @@ -352,4 +352,9 @@ private ClusterState executeClusterStateUpdateTask(ClusterState state, Runnable | |||
| assertThat(result[0], notNullValue()); | |||
| return result[0]; | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| private static <T, R, E extends Exception> CheckedFunction<T, R, E> anyCheckedFunction() { | |||
There was a problem hiding this comment.
I feel like we've duplicated this enough times it might make sense to add it to ESTestCase or some other test utility.
|
@elasticmachine run elasticsearch-ci/part-1 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/part-1 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 11, 2021
In elastic#76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2021
In #76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Aug 11, 2021
Closes elastic#40366. Fix the last remaining javac issues when linting is enforced in `server/`.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 11, 2021
In elastic#76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
nik9000
added a commit
that referenced
this pull request
Aug 11, 2021
In #76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40366.
Fix the last remaining javac issues when linting is enforced in
server/.