Make ip field parsing easier to read #76363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>non-issue
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
This makes the IP parsing code in `IpFieldMapper` a little easier to read by removing the string/object juggling. It also pulls the value parsing bit out into a very sensible and readable method. As a bonus, this method is reusable and we *do* plan to reuse it.
nik9000
added
auto-backport
💔 Backport failed
To backport manually run: |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 11, 2021
This makes the IP parsing code in `IpFieldMapper` a little easier to read by removing the string/object juggling. It also pulls the value parsing bit out into a very sensible and readable method. As a bonus, this method is reusable and we *do* plan to reuse it.
I've done it myself. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2021
This makes the IP parsing code in `IpFieldMapper` a little easier to read by removing the string/object juggling. It also pulls the value parsing bit out into a very sensible and readable method. As a bonus, this method is reusable and we *do* plan to reuse it.
|
Backported in #76369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the IP parsing code in
IpFieldMappera little easier toread by removing the string/object juggling. It also pulls the value
parsing bit out into a very sensible and readable method. As a bonus,
this method is reusable and we do plan to reuse it.