Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointer fix for field capabilities API #76742

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

markharwood
Copy link
Contributor

@markharwood markharwood commented Aug 20, 2021

Composite runtime fields do not have a mapped type for the root - add null check in field capabilities.

Closes #76716

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this bug?

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Mark!

@dnhatn dnhatn added v7.15.1 :Search Foundations/Mapping Index mappings, including merging and defining field types labels Aug 20, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@markharwood markharwood merged commit 81e0bc2 into elastic:master Aug 23, 2021
markharwood added a commit to markharwood/elasticsearch that referenced this pull request Aug 23, 2021
Composite runtime fields do not have a mapped type - add null check, test and Nullable annotation to SearchExecutionContext.getObjectMapper(name)

Closes elastic#76716
markharwood added a commit to markharwood/elasticsearch that referenced this pull request Aug 23, 2021
Composite runtime fields do not have a mapped type - add null check, test and Nullable annotation to SearchExecutionContext.getObjectMapper(name)

Closes elastic#76716
markharwood added a commit that referenced this pull request Aug 23, 2021
Composite runtime fields do not have a mapped type - add null check, test and Nullable annotation to SearchExecutionContext.getObjectMapper(name)

Closes #76716
markharwood added a commit to markharwood/elasticsearch that referenced this pull request Aug 25, 2021
Composite runtime fields do not have a mapped type - add null check, test and Nullable annotation to SearchExecutionContext.getObjectMapper(name)

Closes elastic#76716
markharwood added a commit that referenced this pull request Aug 25, 2021
Composite runtime fields do not have a mapped type - add null check, test and Nullable annotation to SearchExecutionContext.getObjectMapper(name)

Closes #76716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.15.1 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

field_caps Throws NPE when running against composite runtime fields
5 participants